Skip to content

BUG/CLN: clarified timedelta inferences #5995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2014

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jan 18, 2014

closes #5458
closes #5695
closes #5689

cleaned up / clarified timedelta inferences, bottom line is the following works, previously these would
return not-useful object dtypes


In [4]: Series([np.timedelta64(1,'s'),timedelta(days=1),pd.NaT])
Out[4]: 
0   0 days, 00:00:01
1   1 days, 00:00:00
2                NaT
dtype: timedelta64[ns]

…prescence NaT/None/NaN

     from object dtypes (GH5689)
CLN: refactor of timedelta routines to cython for inclusion in maybe_convert_objects
ENH: improved timedelta inference for non-ns dtypes
TST: skip tests on numpy < 1.7 as needed for timedeltas

BUG: fixup .abs for timedeltas
jreback added a commit that referenced this pull request Jan 20, 2014
BUG/CLN: clarified timedelta inferences
@jreback jreback merged commit bbb9e52 into pandas-dev:master Jan 20, 2014
@ghost
Copy link

ghost commented Jan 24, 2014

I suspect this borked some tests on SPARC.
http://nipy.bic.berkeley.edu/tgrid?category=pandas

can't figure out exactly which commit broke it, because buildbot hides history
and @yarikoptic isn't playing ball with ScatterCI :)

@jreback
Copy link
Contributor Author

jreback commented Jan 24, 2014

ok...i'll take a loook...these take forever to build...

@ghost
Copy link

ghost commented Jan 24, 2014

I know. and now he's started submitting s390 bugs. lord help us.

@jreback
Copy link
Contributor Author

jreback commented Jan 26, 2014

@ghost
Copy link

ghost commented Jan 26, 2014

Nice. it really is an uphill struggle.

@jreback
Copy link
Contributor Author

jreback commented Jan 26, 2014

keep pushing on status ci

maybe you could even scrape it? (not ideal but might work)

@ghost
Copy link

ghost commented Jan 26, 2014

What do you think I've been writing for the last 4 hours?

@jreback
Copy link
Contributor Author

jreback commented Jan 26, 2014

4 hours

thought u are a web guru :)

@ghost
Copy link

ghost commented Jan 27, 2014

It's not structured. it's not even HTML. there are special cases.
I have to scrape the log without introducing bad data using monster regex's.
I have to add lots of logging, so I know what happened when data stopped updating.
I have to code defensively, do partsing errors to cause the script to die.
Then, I have to generate a valid xunit xml from the scraped data to submit to the server.
Then, I have to manufacture a fictitious env json description, because I don't
have access to the actual environment. So I have to research what debian sparc
reports when using python's platform module.
then, I have to update the UI to reflect different architectures on top of different OS.
then, I have to setup a cron job.
Then, I have to scrape all the builds retroactively.
Find bugs.
fix them
try again.

in short: don't be an *.

@ghost
Copy link

ghost commented Jan 27, 2014

Sorry, I'm a little pissed off that I have to do all this work for no good reason.
And it's all, really, to save you some pain in supporting SPARC.

so. don't be an *.

@jreback
Copy link
Contributor Author

jreback commented Jan 27, 2014

just joshing you

don't take personally

didn't mean for u to do extra work

they should provide an easier interface if they expect us to support them

@ghost
Copy link

ghost commented Jan 27, 2014

I'm not mad and people have genuinely more important things to take care of.
It's all good. Just about done anyway, check out the page in a few minutes.

@jreback
Copy link
Contributor Author

jreback commented Jan 27, 2014

@y-p whoosh that is awesome!!!

any idea of the build frequency....once a day or so?

@ghost
Copy link

ghost commented Jan 27, 2014

The buildbot builds every 5 hours.
It seems it doesn't test only commits whose first parent is on master. For example
it may test a commit that's the 6th in merge that added 12.
So not only is it low-frequency, but many of those builds don't coincide with the
commits the rest of our CI boxes test. oh well.

Also seems different slaves test different commits according to when they become
available, randomly. So you don't get good coverage of a specific commit, more
like scattershot.

@jreback
Copy link
Contributor Author

jreback commented Jan 27, 2014

ok but will show red soon after something breaks so at least we know
I check your status page somewhat frequently so won't be suprised nearing the end of a release cycle
(like windows used 2 do)

@ghost
Copy link

ghost commented Jan 27, 2014

The next step is email notifications, if there's demand for it. Would it be useful?

@jreback
Copy link
Contributor Author

jreback commented Jan 27, 2014

actually I think that would be quite useful

ideally message on a failure (just 1 per commit is enough)
then message when fixed

if that too tricky then just in a failure is ok

I would send to usual suspects

@ghost
Copy link

ghost commented Jan 27, 2014

It'll be a CI mailing list, open to whomever is interested.

Probably within a few weeks.

@jreback
Copy link
Contributor Author

jreback commented Jan 27, 2014

gr8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant